Re: [PLUG] First shell script for deployment...

[Julien Vehent <julien@linuxwall.info>]

On 2012-04-26 18:49, bergman@merctech.com wrote:
> Paul,
>
> Sorry if I came off as too harsh in my earlier mail.
>
> I forgot to add what is the probably the most important comment:
>
> 	You did a terrific thing by asking for constructive
> 	criticism. Regardless of who we are, we can all improve by this
> 	kind of review, and teach others by showing our work. Asking
> 	someone else to look at your work is often much harder than
> 	doing the work itself.


I second that. At $work we are now imposing the same level of review than 
what is expected of the developers. We do that via github (enterprise) pull 
requests, and for every provisioning script we write.
Having a fellow sysadmin review your ruby script is hard, really hard, but 
there's no argument that is it beneficial.

- Julien
___________________________________________________________________________
Philadelphia Linux Users Group         --        http://www.phillylinux.org
Announcements - http://lists.phillylinux.org/mailman/listinfo/plug-announce
General Discussion  --   http://lists.phillylinux.org/mailman/listinfo/plug