|
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
|
Re: [tcptra-dev] tcptraceroute-1.5beta7
|
On Thu, Mar 30, 2006 at 12:26:36AM +0400, Dmitry V. Levin wrote:
> I have few patches made long time ago for beta5 and later rediffed for
> beta6. The most obvious one is attached.
Hi Dmitry,
> if (device == NULL)
> - fatal("Could not determine device via pcap_lookupdev(): %\n", errbuf);
> + fatal("Could not determine device via pcap_lookupdev(): %s\n", errbuf);
Oops. Thanks, I've incorporated the change.
Regarding the other changes you posted, which are specific to gcc:
> -void fatal(char *, ...);
> +void fatal(char *, ...) TCPTRACEROUTE_NORETURN TCPTRACEROUTE_FORMAT((__printf__, 1, 2));
I'm not sure I see the additional benefit compared the complexity it
introduces?
Thanks,
-mct
_______________________________________________
tcptraceroute-dev mailing list
tcptraceroute-dev@netisland.net
http://lists.netisland.net/mailman/listinfo/tcptraceroute-dev
|
|